Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GOES data retrieval to include NOAA's CLAss archive #249

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

14Richa
Copy link
Contributor

@14Richa 14Richa commented Mar 29, 2024

Pull Request

Description

This PR adds a new function download_archival_goes_data to the GOESDownloadManager class. This function allows users to download archival GOES data from NOAA's CLASS archive.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings

@14Richa
Copy link
Contributor Author

14Richa commented Apr 3, 2024

Hey @jacobbieker, as discussed, I have extended the GOESDownloadManager with 'NOAS' for archival data. Please review when you get time.

@jacobbieker
Copy link
Member

Hi, thanks for adding this! I might have misspoke with the archival data that I meant. From CLAss we want to be able to download the GOES-8 to GOES-15 data (available here: https://www.aev.class.noaa.gov/saa/products/search?datatype_family=GVAR_IMG). This might also work for that, but not sure, could you check?

@14Richa
Copy link
Contributor Author

14Richa commented Apr 5, 2024

Hi, thanks for adding this! I might have misspoke with the archival data that I meant. From CLAss we want to be able to download the GOES-8 to GOES-15 data (available here: https://www.aev.class.noaa.gov/saa/products/search?datatype_family=GVAR_IMG). This might also work for that, but not sure, could you check?

Hey @jacobbieker, Thank you for clarifying the requirements.

I've updated the code to check the provided URL for the availability of GOES-8 to GOES-15 data before proceeding with the download. If the data is found, it will be downloaded for each satellite in the specified range.

@jacobbieker
Copy link
Member

jacobbieker commented Apr 5, 2024

Great! Thank you. Have you tested this? And could you add a test for downloading GOES-15 data from CLAss? And have it actually download the file too, as it shouldn't be that large.

@14Richa
Copy link
Contributor Author

14Richa commented Apr 10, 2024

Great! Thank you. Have you tested this? And could you add a test for downloading GOES-15 data from CLAss? And have it actually download the file too, as it shouldn't be that large.

Yes, I've tested it locally, and it is working fine. I've also added a unit test for it.

@jacobbieker
Copy link
Member

Okay, great! Just closing and reopening to trigger our CI, once these pass, should be almost good to go!

@jacobbieker jacobbieker reopened this Apr 11, 2024
@jacobbieker jacobbieker merged commit ed3320b into openclimatefix:main Apr 11, 2024
1 of 3 checks passed
@jacobbieker
Copy link
Member

Hi, I'm not sure this actually does what we want unfortunately, it downloads a HTML file, but not the NetCDF file from GOES-15 from CLAss, so we might want to do some more work on this!

@14Richa
Copy link
Contributor Author

14Richa commented Apr 16, 2024

Hi, I'm not sure this actually does what we want unfortunately, it downloads a HTML file, but not the NetCDF file from GOES-15 from CLAss, so we might want to do some more work on this!

Hi @jacobbieker , I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants