Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for empty generation vals before resampling #65

Merged
merged 1 commit into from
Jun 18, 2024
Merged

check for empty generation vals before resampling #65

merged 1 commit into from
Jun 18, 2024

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Jun 18, 2024

Pull Request

Description

Prevent resampling error when no generation data is available

How Has This Been Tested?

Local API with Postman + local UI

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf self-assigned this Jun 18, 2024
@braddf braddf merged commit c17458e into main Jun 18, 2024
8 checks passed
@braddf braddf deleted the fix/resampling-empty-check branch June 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees

@braddf braddf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@braddf @peterdudfield