Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Topological ML data #10

Closed
peterdudfield opened this issue Oct 20, 2021 · 0 comments
Closed

Topological ML data #10

peterdudfield opened this issue Oct 20, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@peterdudfield
Copy link
Collaborator

Describe the bug
Topological data is not coverted from xr.Dataset properly

To Reproduce
run this tests/test_netcdf_dataset.py and see that batchML has not topological data in it

** additional context **
These files are being moved from nowcasting_dataset, so its good not didnt want to make this change there.

Currently:

  •    if TOPOGRAPHIC_DATA in xr_dataset.keys():
    
  •        return TopographicML(
    
  •            batch_size=xr_dataset[TOPOGRAPHIC_DATA].shape[0],
    
  •            topo_data=xr_dataset[TOPOGRAPHIC_DATA],
    
  •            topo_x_coords=xr_dataset[TOPOGRAPHIC_DATA].topo_x,
    
  •            topo_y_coords=xr_dataset[TOPOGRAPHIC_DATA].topo_y,
    
  •        )
    
  •    else:
    
  •        return None
    

Potential solution
+

  •    return TopographicML(
    
  •        batch_size=xr_dataset.data.shape[0],
    
  •        topo_data=xr_dataset.data,
    
  •        topo_x_coords=xr_dataset.x,
    
  •        topo_y_coords=xr_dataset.y,
    
  •    )
    
@peterdudfield peterdudfield added the bug Something isn't working label Oct 20, 2021
jacobbieker added a commit that referenced this issue Oct 20, 2021
@peterdudfield peterdudfield added this to To do in National Grid Nowcasting: WP1 via automation Oct 20, 2021
National Grid Nowcasting: WP1 automation moved this from To do to Done Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant