This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
hrv_satellite_fake should return the requested image_size_pixels, not 3 x image_size_pixels
#693
Assignees
Labels
bug
Something isn't working
Comments
JackKelly
changed the title
hrv_satellite_fake should return the requested image_size_pixels, not 3x image_size_pixelshrv_satellite_fake should return the requested image_size_pixels, not 3 x image_size_pixels
3 tasks
|
Yea, you can remove the *3. Sorry about that |
|
No worries at all! I'll submit a PR in a few mins 🙂 |
JackKelly
added a commit
that referenced
this issue
Jun 28, 2022
… 3 x image_size_pixels. Issue #693
Merged
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
If you ask
hrv_satellite_fakefor an image 256 pixels wide by 128 pixels high then it'll return an image of shape 768 wide x 384 high.Which, presumably, is because of the
* 3on lines 376 & 377 ofbatch.py:@peterdudfield is it safe to simply remove the
* 3from those lines? 🙂Yes, the HRV images are higher resolution than the other satellite channels. But the
configurationrequests the image size in pixels, so, if I've understood correctly, the HRV images should always be exactly the pixel sizes that were requested in the config?The text was updated successfully, but these errors were encountered: