This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
removing scaling for gsp, but add capacity #427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
requested review from
JackKelly and
jacobbieker
and removed request for
JackKelly
peterdudfield
commented
Nov 17, 2021
| @@ -11,7 +11,7 @@ class GSP(DataSourceOutput): | |||
|
|
|||
| __slots__ = () | |||
| _expected_dimensions = ("time", "id") | |||
| _expected_data_vars = ("data", "pv_system_row_number", "x_coords", "y_coords") | |||
| _expected_data_vars = ("data", "capacity_mwh", "pv_system_row_number", "x_coords", "y_coords") | |||
There was a problem hiding this comment.
do you think "data" should be change to "power_mw" to make it really clear, @JackKelly @jacobbieker
|
Ill close this for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes #231
How Has This Been Tested?
unittests
Checklist: