Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Implement geostationary coords for fake satellite batches. #701

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Implement geostationary coords for fake satellite batches. #701

merged 2 commits into from
Jun 29, 2022

Conversation

JackKelly
Copy link
Member

Pull Request

Description

Fixes #697

How Has This Been Tested?

  • Yes, unittests pass

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly added the enhancement New feature or request label Jun 29, 2022
@JackKelly JackKelly self-assigned this Jun 29, 2022
@JackKelly JackKelly marked this pull request as draft June 29, 2022 10:56
@JackKelly
Copy link
Member Author

JackKelly commented Jun 29, 2022 •
edited

oh, wait, there's a bug...

image

@JackKelly JackKelly marked this pull request as ready for review June 29, 2022 11:06
@JackKelly JackKelly mentioned this pull request Jun 29, 2022
Closed
@JackKelly JackKelly merged commit d56934e into main Jun 29, 2022
@JackKelly JackKelly deleted the jack/geostationary_coords_for_fake_batches branch June 29, 2022 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees

@JackKelly JackKelly

Labels
enhancement New feature or request
Projects
No open projects
Nowcasting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fake hrvsatellite and satellite batches need geostationary coords
2 participants
@JackKelly @peterdudfield