feat(inputs): Meteomatics downloader #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a NWP Consumer client for Meteomatics. For the sake of time, the differences between the meteomatics API and other sources of NWP data have not been taken into account in a more clever way than offloading much of the modified logic to the implementation of the FileInfoModel. As such, there's more hardcoding than I'd like, as well as less customization and parameterisation.
This is mostly due to the fact that the dataset we are pulling from meteomatics is not a gridded dataset, but rather a timeseries over a set of specific coordinates. These changes negate the use of the
areaparameter from the FileInfoModel. When I have time, it would be good to revisit this so it can have its sites chosen via env vars like for instance how the parameterGroups works with other inputs.