analysis dashboard access to satellite bucket #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryanbhosale
changed the title
… of s3_nwp_buckets
I get this error |
|
Do you need to remove this one - https://github.com/openclimatefix/ocf-infrastructure/blob/external-pr/terraform/modules/services/eb_app/iam.tf#L128 |
Yes, ill make the change , thank you for pointing it out |
I have removed this |
peterdudfield
added a commit
that referenced
this pull request
Apr 15, 2024
* analysis dashboard access to satellite bucket (#482) * added var s3_nwp_buckets * analysis dashboard access to satellite bucket * added variables.tfvars * Refactor: Modify s3_nwp_bucket variable to accept a list of bucket ARNs * updated modules in india/dev & nowcasting/dev to include the new list of s3_nwp_buckets * removed conflicting role policy attachment code (#487) * added var s3_nwp_buckets * analysis dashboard access to satellite bucket * added variables.tfvars * Refactor: Modify s3_nwp_bucket variable to accept a list of bucket ARNs * updated modules in india/dev & nowcasting/dev to include the new list of s3_nwp_buckets * removed old role policy attachment resource conflicting code --------- Co-authored-by: Peter Dudfield <34686298+peterdudfield@users.noreply.github.com> --------- Co-authored-by: Aryan Bhosale <36108149+aryanbhosale@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: