Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solar generation to reflect correct value #484

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

rachel-labri-tipton
Copy link
Contributor

@rachel-labri-tipton rachel-labri-tipton commented Mar 12, 2024

Pull Request

Description

The total generation numbers were not adding up correctly. The solar card was not reflecting the right solar generation number. I've changed this and total power should now add up correctly.

Fixes #483

How Has This Been Tested?

Ran the code locally.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quartz-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 1:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nowcasting-app ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 1:30pm

@rachel-labri-tipton
Copy link
Contributor Author

hey @braddf, let me know if you're ok for me to merge. thanks for catching the small error.

@rachel-labri-tipton rachel-labri-tipton merged commit 1b9bf15 into india-mvp Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants