This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Update PyTorch Lightning models for supporting Nowcasting Dataset Dicts #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbieker
changed the title
|
Tests pass with the dev version of nowcasting-dataset. Need topographic support to be merged to make these pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Updates the SatFlow models to more explicitly work with the nowcasting dataset output dicts. Primarily involves updating the input modalities for Perceiver, as well as combining before input for MetNet.
Fixes issue #98
Relates to openclimatefix/perceiver-pytorch#16 as Perceiver will now use the LearnableQuery
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: