Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8: Add Youtube icon to footer with the channel link. #13

Merged
merged 2 commits into from Oct 26, 2019

Conversation

hansal7014
Copy link
Contributor

What changes are being made? (feature/bug)

Adds a youtube icon to the website footer that is linked to the website's youtube channel.

Why are these changes necessary? Link any related issues

Adds an icon as requested in issue #8.

Unit Test

@JackKelly
Copy link
Member

Wow - thank you so much for helping, @hansal7014 ! Great work!

(I'll leave it to Flo to review and merge the PR. But thanks so much for doing this work; and for documenting the change so nicely!)

Copy link
Contributor

@flowirtz flowirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for contributing Hansal!

Just one tiny comment.
Make sure to run the linter via yarn run lint before submitting next time. 😊

src/components/Footer/Footer.jsx Outdated Show resolved Hide resolved
@flowirtz

This comment has been minimized.

@allcontributors

This comment has been minimized.

Copy link
Contributor

@flowirtz flowirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flowirtz flowirtz merged commit c5bf1ee into openclimatefix:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants