Added proper openGraph support - Fixes #11 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowirtz
requested changes
Oct 30, 2019
There was a problem hiding this comment.
Amazing, thanks @drwm-base!
I also found this tag which somehow links our twitter account, would probably be good to include as well with this.
{
name: 'twitter:site',
content: '@OpenClimateFix',
},
Co-Authored-By: Flo <FWirtz@users.noreply.github.com>
|
I'll finish it up later tonight, I'm not around my coding environment right now. |
|
@fwirtz I have made the changes you requested, please let me know if there is anything else I can do? And thanks for getting back to me so quickly! :) |
flowirtz
approved these changes
Oct 31, 2019
|
@all-contributors please add @drwm-base for code please |
|
I've put up a pull request to add @drwm-base! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
I added the github raw image as the source for the openGraph image. I also made a version for twitter, although I don't think it actually needs a different version as when I tested it, it worked fine without the twitter entries.