Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper openGraph support - Fixes #11 #27

Merged
merged 5 commits into from Oct 31, 2019

Conversation

@drwm-base
Copy link
Contributor

drwm-base commented Oct 28, 2019

Fixes #11

I added the github raw image as the source for the openGraph image. I also made a version for twitter, although I don't think it actually needs a different version as when I tested it, it worked fine without the twitter entries.

@drwm-base drwm-base requested a review from FWirtz as a code owner Oct 28, 2019
Copy link
Contributor

FWirtz left a comment

Amazing, thanks @drwm-base!

I also found this tag which somehow links our twitter account, would probably be good to include as well with this.

{
    name: 'twitter:site',
    content: '@OpenClimateFix',
},
src/components/seo.jsx Outdated Show resolved Hide resolved
Co-Authored-By: Flo <FWirtz@users.noreply.github.com>
@drwm-base

This comment has been minimized.

Copy link
Contributor Author

drwm-base commented Oct 30, 2019

I'll finish it up later tonight, I'm not around my coding environment right now.

@drwm-base

This comment has been minimized.

Copy link
Contributor Author

drwm-base commented Oct 30, 2019

@FWirtz I have made the changes you requested, please let me know if there is anything else I can do? And thanks for getting back to me so quickly! :)

@drwm-base drwm-base requested a review from FWirtz Oct 30, 2019
@FWirtz
FWirtz approved these changes Oct 31, 2019
Copy link
Contributor

FWirtz left a comment

Amazing thanks so much!

@FWirtz FWirtz self-assigned this Oct 31, 2019
@FWirtz FWirtz merged commit 08b8a58 into openclimatefix:master Oct 31, 2019
1 check passed
1 check passed
stickler-ci No lint errors found
Details
@FWirtz

This comment has been minimized.

Copy link
Contributor

FWirtz commented Oct 31, 2019

@all-contributors please add @drwm-base for code please

@allcontributors

This comment has been minimized.

Copy link
Contributor

allcontributors bot commented Oct 31, 2019

@FWirtz

I've put up a pull request to add @drwm-base! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.