Small changes to SBML loading #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces read time by ~35% for Salmonella.
The docstring has been updated to state that the only allowed characters are letters and numbers. Warnings are explicitly raised for parenthesis and '*' in a formula string.
This is case is now handled. The metabolite will not be added if it is on both sides with the same stoichiometry.
danielhyduke
added a commit
that referenced
this pull request
Nov 2, 2014
Small changes to SBML loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will handle SBML with metabolites on both sides of a reaction. A warning will be raised in this case, however. More warnings are raised for invalid formulas as well.