New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FVA in summary calls #525

Merged
merged 3 commits into from Jun 19, 2017

Conversation

Projects
None yet
3 participants
@pstjohn
Contributor

pstjohn commented Jun 15, 2017

We've got bigger issues, #520, but this fixes a bug with the FVA handling in summary.

pstjohn added some commits Jun 15, 2017

@pstjohn pstjohn added the ready label Jun 15, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 15, 2017

Codecov Report

Merging #525 into devel will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #525      +/-   ##
==========================================
+ Coverage   69.43%   69.43%   +<.01%     
==========================================
  Files          64       64              
  Lines        8476     8477       +1     
  Branches     1447     1447              
==========================================
+ Hits         5885     5886       +1     
  Misses       2334     2334              
  Partials      257      257
Impacted Files Coverage Δ
cobra/flux_analysis/summary.py 80.64% <25%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a6255...fcfbf7d. Read the comment docs.

codecov-io commented Jun 15, 2017

Codecov Report

Merging #525 into devel will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #525      +/-   ##
==========================================
+ Coverage   69.43%   69.43%   +<.01%     
==========================================
  Files          64       64              
  Lines        8476     8477       +1     
  Branches     1447     1447              
==========================================
+ Hits         5885     5886       +1     
  Misses       2334     2334              
  Partials      257      257
Impacted Files Coverage Δ
cobra/flux_analysis/summary.py 80.64% <25%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a6255...fcfbf7d. Read the comment docs.

@pstjohn

This comment has been minimized.

Show comment
Hide comment
@pstjohn

pstjohn Jun 15, 2017

Contributor

yeah I should probably write tests for these... lets see what happens in #520

Contributor

pstjohn commented Jun 15, 2017

yeah I should probably write tests for these... lets see what happens in #520

@hredestig

cheers for the intermediate improvement!

@hredestig hredestig merged commit a41c887 into opencobra:devel Jun 19, 2017

3 of 4 checks passed

codecov/patch 25% of diff hit (target 69.43%)
Details
codecov/project 69.43% (+<.01%) compared to 66a6255
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hredestig hredestig removed the ready label Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment