Merge pull request #598 from opencobra/errored_when_skipped

Errored when skipped
opencobra · Jan 28, 2019 · 225d8c2 · 225d8c2
2 parents 3867f09 + aab3fbe
commit 225d8c2
Show file tree

Hide file tree

Showing 4 changed files with 3,879 additions and 2,120 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -47,6 +47,7 @@ Next Release
 * Refactor test that identifies duplicate metabolites to use for inchi
   strings in addition to inchikeys.
 * Round score to and display a single decimal value.
+* Fix bug that would show a test as errored whenever it was marked as skipped.
 * Read SBML files with modified parser that can collect the level, version and
   whether the FBC package is used.
 * Validate the SBML structure with the libSBML python API if the parser errors

diff --git a/memote-report-app/src/app/test-result.model.ts b/memote-report-app/src/app/test-result.model.ts
@@ -10,7 +10,7 @@ export class TestResult {
   public format_type: string;
 
   private errorFailsafe(result: string) {
-    if (this.result !== 'skipped' && (this.data === null || typeof this.data === 'undefined') ) {
+    if (result !== 'skipped' && (this.data === null || typeof this.data === 'undefined') ) {
       this.result = 'error';
     } else {
       this.result = result;