Skip to content

Commit

Permalink
feat: improve report interface by adding clear scoring (#564)
Browse files Browse the repository at this point in the history
* feat: add empty score-formula component.

* feat: add summation-style subscores to the scored report side.

* feat: exclude subtotal from history report view.

* feat: calculate and show total formulae.

* feat: compose formulae for sections.

* fix: remove inconsistencies from snapshot report test data.

* feat: add scoring function formula as SVG.

* feat: display weights for each test case.

* chore: update angular from 5.1.0 to 7.2.0

* fix: remove errors associated with weight badges

* feat: clarify differences between sections.

* fix: avoid typescript errors when reading vega specs.

* feat: add multiplier to badge and center text.

* docs: fix total formula SVG in the readme modal

* fix node assert issue by running npm i natives.

* fix: correct sizing and scaling of text and move SVG to readme modal.

* chore: bundle reports.

* chore: update history.rst

* fix: adjust condition such that false data would not count as null or undefined data.

* chore: update history.rst

* chore: bundle reports.

* fix: stop errored parametrized tests from disappearing from the report

* chore: update history.rst and generate the report template

* fix: swap equality equals operator to identity equals operator
  • Loading branch information
ChristianLieven committed Jan 18, 2019
1 parent 1747272 commit 4f7dfc3
Show file tree
Hide file tree
Showing 37 changed files with 9,667 additions and 6,469 deletions.
11 changes: 11 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@ History

Next Release
------------
* Update memote-report-app from Angular 5.1.0 to 7.2.0.
* Reduce the prominence of the total score in the reports.
* Provide partial calculations for each section.
* Show overall formula of how the total score is calculated.
* Clearly indicate weights/ multipliers by introducing margenta badges next to each test in the report.
* In the reports, improve the descriptions of the 'Help' section and rename this section to 'Readme'.
* Rename the principal sections and include a brief explanation for each.
* Fix bug that would show a test as 'Errored' although it only failed. Fixed by making condition in errorFailsafe
in test-result.model.ts more specific for cases where data is undefined or null.
* Fix bug that would make parametrized tests disappear from the report if they had errored or if for some reason their 'data' attribute
was undefined.
* Unpin pytest (require >= 4.0) and adjust some internal mechanics accordingly.
* Display an alternative message if some biomass components do not contain a
formula.
Expand Down
61 changes: 0 additions & 61 deletions memote-report-app/.angular-cli.json

This file was deleted.

134 changes: 134 additions & 0 deletions memote-report-app/angular.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
{
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"version": 1,
"newProjectRoot": "projects",
"projects": {
"memote-report-app": {
"root": "",
"sourceRoot": "src",
"projectType": "application",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"outputPath": "dist",
"index": "src/index.html",
"main": "src/main.ts",
"tsConfig": "src/tsconfig.app.json",
"polyfills": "src/polyfills.ts",
"assets": [
"src/assets",
"src/favicon.ico",
"src/data"
],
"styles": [
"src/styles.scss"
],
"scripts": []
},
"configurations": {
"production": {
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"fileReplacements": [
{
"replace": "src/environments/environment.ts",
"with": "src/environments/environment.prod.ts"
}
]
}
}
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "memote-report-app:build"
},
"configurations": {
"production": {
"browserTarget": "memote-report-app:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "memote-report-app:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "src/test.ts",
"karmaConfig": "./karma.conf.js",
"polyfills": "src/polyfills.ts",
"tsConfig": "src/tsconfig.spec.json",
"scripts": [],
"styles": [
"src/styles.scss"
],
"assets": [
"src/assets",
"src/favicon.ico",
"src/data"
]
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"src/tsconfig.app.json",
"src/tsconfig.spec.json"
],
"exclude": [
"**/node_modules/**"
]
}
}
}
},
"memote-report-app-e2e": {
"root": "e2e",
"sourceRoot": "e2e",
"projectType": "application",
"architect": {
"e2e": {
"builder": "@angular-devkit/build-angular:protractor",
"options": {
"protractorConfig": "./protractor.conf.js",
"devServerTarget": "memote-report-app:serve"
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"e2e/tsconfig.e2e.json"
],
"exclude": [
"**/node_modules/**"
]
}
}
}
}
},
"defaultProject": "memote-report-app",
"schematics": {
"@schematics/angular:component": {
"prefix": "app",
"styleext": "scss"
},
"@schematics/angular:directive": {
"prefix": "app"
}
}
}
10 changes: 4 additions & 6 deletions memote-report-app/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,22 @@
module.exports = function (config) {
config.set({
basePath: '',
frameworks: ['jasmine', '@angular/cli'],
frameworks: ['jasmine', '@angular-devkit/build-angular'],
plugins: [
require('karma-jasmine'),
require('karma-chrome-launcher'),
require('karma-jasmine-html-reporter'),
require('karma-coverage-istanbul-reporter'),
require('@angular/cli/plugins/karma')
require('@angular-devkit/build-angular/plugins/karma')
],
client:{
clearContext: false // leave Jasmine Spec Runner output visible in browser
},
coverageIstanbulReporter: {
reports: [ 'html', 'lcovonly' ],
dir: require('path').join(__dirname, 'coverage'), reports: [ 'html', 'lcovonly' ],
fixWebpackSourcePaths: true
},
angularCli: {
environment: 'dev'
},

reporters: ['progress', 'kjhtml'],
port: 9876,
colors: true,
Expand Down

0 comments on commit 4f7dfc3

Please sign in to comment.