Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some hacks to make webpack compile with node 13.5 #131

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

manisabri
Copy link
Contributor

@manisabri manisabri commented Jun 24, 2020

reg issue #130

@ngeiswei
Copy link
Member

ngeiswei commented Jul 7, 2020

Could someone with more understanding than I approve this PR? I'd rather merge with some oversight, @Habush, @linas?

@linas
Copy link
Member

linas commented Jul 8, 2020

Merging. This seems fairly typical of the kinds of changes that npm-based systems need to have every so often (I use an unrelated npm system out of github, and they make commits like this every few weeks. Something about that style of coding.)

(Well, I'm making this comment because I'm not an expert on this stuff; but as it seems more-or-less unmaintained... heck, seems OK to me.)

Anyway, thanks @manisabri !

@linas linas merged commit d61a736 into opencog:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants