Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HIDE_MORPHO from compute_chosen_words #39

Open
linas opened this issue Dec 16, 2014 · 2 comments
Open

Remove HIDE_MORPHO from compute_chosen_words #39

linas opened this issue Dec 16, 2014 · 2 comments

Comments

@linas
Copy link
Member

linas commented Dec 16, 2014

compute_chosen_words() should be factored to remove the HIDE_MORPHO stuff, and the HIDE_MORPHO should be a distinct step.

The current implementation of HIDE_MORPHO in compute_chosen_words is not quite right: it assumes that only the suffix has connectors attaching to other parts of the sentence, and so fails to merge the disjuncts correctly if this rule is broken.

@ampli
Copy link
Member

ampli commented Dec 16, 2014

My current (i.e. in the Wordgraph version) implementation of HIDE_MORPHO removes only the LL links, and leaves the other links intact. However, I had to set the chosen_words correspondent to the hidden (Hebrew) morphemes to " " (blank) instead of NULL, else the linkage_print_diagram_ctxt() segfaults...

Words in chosen_words corresponding to stems are sill NULLed in my version, but if a stem would have other links then LL, the said segfault will occur. All of this can be fixed.

Since a general HIDE_MORPHO code is not trivial, it may indeed be a good idea to do it in a separate step.

@linas
Copy link
Member Author

linas commented Dec 17, 2014

once the dict is built, it should not be modied -- if it is, that would cause multi-threading issues. Clearly no one is multi-threading .. but hey .. anway, many of these routines should be marked to have const arguments, to avoid such issues.

@ampli ampli mentioned this issue Aug 15, 2015
ampli added a commit to ampli/link-grammar that referenced this issue Jan 11, 2016
This code is not complete yet.
FIXME: The HIDE_MORPHO code should be moved to a separate function, per
issue opencog#39.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants