A additional fix for issue #1247 ++ #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ampli
commented
Sep 16, 2021
ampli
commented
- Fix bad initial size of the "category" Disjunct field. Now it seems trivial but I had to install a vm for armv7l and use gdb...
- On the same occasion: Fix non-portable union field order in Disjunct_struct (not a problem for this issue).
Only triggers during generation. For issue opencog#1247.
The code depends on is_category and num_categories to use identical memory location. This would get violated if sizeof(int)!=sizeof(float) or sizeof(char *)!=sizeof(Category_cost *). Fixed by staring with is_category and num_categories, so they are guaranteed to use the same memory.
Of course! That should have obvious! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.