Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add CI for CLANG64 environment of MSYS2 #459

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Conversation

mmuetzel
Copy link
Contributor

Pull request purpose

Add CI for CLANG64 environment of MSYS2.
Add runners for different configurations (MPI, INTERFACE64) on MinGW-w64.

This picks up on #415.

Detailed changes proposed in this pull request

The CLANG64 environment of MSYS2 uses a toolchain that it almost entirely based on LLVM tools. That includes compilers (incl. LLVM Flang), linker, and LLVM libc++ (instead of GNU's libstdc++). Most common build environments are based on GNU tools (apart from maybe macOS and MSVC on Windows).
It might be worth testing unusual build environments in CI to make sure they don't break unintentionally.

This PR adds runners for that build environment.
It also adds Eigen3 as an additional build dependency on MinGW to test it on that platform.
Additionally, it adds runners for the following configurations (to the UCRT64 and CLANG64 environments):

  • MPI=ON/OFF
  • INTERFACE64=ON/OFF

@mmuetzel
Copy link
Contributor Author

Adding the path to the built libarpack.dll to the PATH variable is just to work around an issue that might better be fixed in the CMake build system.
I'd be happy to look into proposing a change for that. But it would be nice if this could be merged first to make it easier to check if any follow-up change actually works.

@mmuetzel
Copy link
Contributor Author

Is there an obvious reason why arpackmm_tst takes longer on Windows than on, e.g., Ubuntu?
ubuntu_latest_cmake:

      Start 91: arpackmm_tst
91/95 Test #91: arpackmm_tst .....................   Passed   43.28 sec

MinGW-w64 UCRT64 INTERFACE64=OFF/MPI=OFF

      Start 82: arpackmm_tst
82/84 Test #82: arpackmm_tst .....................   Passed  148.70 sec

@fghoussen
Copy link
Collaborator

Could you fix the test that fails?

Is there an obvious reason why arpackmm_tst takes longer on Windows than on, e.g., Ubuntu?

Nope

@mmuetzel
Copy link
Contributor Author

Could you fix the test that fails?

The macOS one?
I don't have local access to macOS. But I can try...

@fghoussen
Copy link
Collaborator

The macOS one?

Yep. No mac too here. I hope pip3 install numpy>=2.0.0could be enough...

@mmuetzel
Copy link
Contributor Author

The macOS one?

Yep. No mac too here. I hope pip3 install numpy>=2.0.0could be enough...

I've opened #460 that should fix the version conflict on that runner.

@sylvestre sylvestre merged commit 77ba50e into opencollab:master Jun 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants