Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontInfo has strange hashCode() #31

Closed
murkle opened this issue Jul 5, 2017 · 1 comment
Closed

FontInfo has strange hashCode() #31

murkle opened this issue Jul 5, 2017 · 1 comment

Comments

@murkle
Copy link
Collaborator

murkle commented Jul 5, 2017

This looks odd, and I can't see a reason for it:

		public int hashCode() {
			return (left + right) % 128;
		}

I suggest:

		public int hashCode() {
			return left + (right << 16);
		}
@murkle
Copy link
Collaborator Author

murkle commented Sep 27, 2018

@murkle murkle closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant