Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure build with java 11 and 12 works #55

Merged
merged 1 commit into from Apr 10, 2019
Merged

Ensure build with java 11 and 12 works #55

merged 1 commit into from Apr 10, 2019

Conversation

davidmoten
Copy link
Collaborator

When building with Java 11 or 12 (openjdk) the build failed with javadoc errors. This PR

  • fixes the javadoc errors (stuff like <, >, & need to be escaped properly in javadoc, and mismatched parameters)
  • upgrades maven-javadoc-plugin to 3.1.0 (latest)
  • adds openjdk11 to the Travis build matrix

OpenJDK 12 is not available yet on Travis but I confirm the build passes with it also.

@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited

Pull Request Test Coverage Report for Build 122

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 58.855%
Totals Coverage Status
Change from base Build 84: 0.05%
Covered Lines: 4556
Relevant Lines: 7741
💛 - Coveralls

@sylvestre
Copy link
Contributor

Thanks!

@sylvestre sylvestre merged commit 3408fec into opencollab:master Apr 10, 2019
@sylvestre
Copy link
Contributor

could you add that to the release notes?
https://github.com/opencollab/jlatexmath/blob/master/CHANGELOG

davidmoten added a commit that referenced this pull request Apr 10, 2019
@davidmoten
Update CHANGELOG #55
7995ce5
@davidmoten
Copy link
Collaborator Author

could you add that to the release notes?

Done (committed directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidmoten @coveralls @sylvestre