fix some build issues #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An attempt to fix basic issues in #76 |
davidmoten
requested changes
Dec 30, 2020
| - oraclejdk8 | ||
| - oraclejdk9 | ||
| - openjdk7 | ||
| - oraclejdk11 | ||
| - openjdk11 |
There was a problem hiding this comment.
add openjdk8 as well please
There was a problem hiding this comment.
The reason I removed these is because older versions fail with: Expected feature release number in range of 9 to 17, but got: 8
I have no idea if this project is dead but it seems some build issues need fixing so this is my first pass at doing so.
snecklifter
force-pushed
the
fix-travis
branch
from
f1d01aa
to
aaf153f
Compare
davidmoten
approved these changes
Dec 31, 2020
|
@davidmoten do we care about this tiny decrease in coverage? |
|
No :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea if this project is dead but it seems some build
issues need fixing so this is my first pass at doing so.