Update PDF util #4742
Merged
Update PDF util #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znarf
reviewed
Oct 21, 2020
server/lib/fetch.js
Outdated
| * @param {Number} [timeoutInMs] The callback to call with the authorized client. Default is 5000 ms. | ||
| */ | ||
|
|
||
| export const fetchWithTimeout = (fetchParams, timeoutInMs = 5000) => { |
There was a problem hiding this comment.
I think it would look better by following fetch API: first argument url, second argument options. timeoutInMs could be read from options or kept as third argument.
sbinlondon
force-pushed
the
pdfupdates
branch
from
f1e5b06
to
496328f
Compare
Betree
reviewed
Oct 22, 2020
I'll keep this in mind and maybe refactor next week when I have a bit more time. Was good to practice promises at least 😅 |
sbinlondon
force-pushed
the
pdfupdates
branch
from
496328f
to
297215c
Compare
znarf
reviewed
Oct 22, 2020
znarf
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Looks good. I'm not sure if that's needed but we could also add Keep-Alive.
Similar to https://github.com/opencollective/opencollective-frontend/blob/master/lib/apollo-client.js#L49
sbinlondon
force-pushed
the
pdfupdates
branch
from
297215c
to
eaaa801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchWithTimeoutwhich takes a URL and options to pass tonode-fetchand a timeout in ms, and returns a thenable promise