Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Events): add support for online events #5649

Merged
merged 1 commit into from Mar 24, 2021
Merged

feat(Events): add support for online events #5649

merged 1 commit into from Mar 24, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 6, 2021 •
edited

@snitin315 snitin315 mentioned this pull request Mar 6, 2021
Merged
@snitin315 snitin315 force-pushed the feat/online-events branch 4 times, most recently from e261ab1 to 6e092ba Compare March 11, 2021 10:58
@snitin315 snitin315 marked this pull request as ready for review March 11, 2021 11:07
Base automatically changed from master to main March 15, 2021 13:26
Betree
Betree requested changes Mar 16, 2021
View reviewed changes
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, most of my feedback is about collective.data that we must treat like something the user should not be able to read or write in its entirety.

server/graphql/v1/CollectiveInterface.js Outdated Show resolved Hide resolved
server/graphql/v1/mutations/collectives.js Show resolved Hide resolved
templates/emails/ticket.confirmed.hbs Outdated Show resolved Hide resolved
@snitin315 snitin315 force-pushed the feat/online-events branch 2 times, most recently from 315c377 to 10fcdc4 Compare March 17, 2021 12:07
@snitin315
Copy link
Member Author

@Betree I have applied the suggestion.

@Betree Betree self-assigned this Mar 24, 2021
@Betree Betree merged commit 689c089 into main Mar 24, 2021
@Betree Betree deleted the feat/online-events branch March 24, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Betree Betree Betree approved these changes

Assignees

@Betree Betree

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snitin315 @Betree