Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Transfer)Wise QuoteV2 Refactor #5726

Merged
merged 4 commits into from
Mar 22, 2021
Merged

(Transfer)Wise QuoteV2 Refactor #5726

merged 4 commits into from
Mar 22, 2021

Conversation

kewitz
Copy link
Contributor

@kewitz kewitz commented Mar 17, 2021

@kewitz kewitz force-pushed the refact/transferwise-quotes-v2 branch 3 times, most recently from d95ef25 to 1969c80 Compare March 17, 2021 21:38
@kewitz kewitz force-pushed the refact/transferwise-quotes-v2 branch from 1969c80 to d2001ec Compare March 19, 2021 21:11
@kewitz kewitz requested a review from Betree March 19, 2021 21:34
@kewitz kewitz merged commit 8ae51c0 into main Mar 22, 2021
@kewitz kewitz deleted the refact/transferwise-quotes-v2 branch March 22, 2021 13:00
@patcon
Copy link
Contributor

patcon commented Mar 22, 2021

Thanks so much @kewitz and OC team 🙌

Is this now immediately on prod? (If so, I will happily drop my mentioning shortfall interac fees as caveat during onboarding of collectives :)

cc @benhylau

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@patcon I think this has not been deployed in production yet

const pRequest = data ? fn(url, data, options) : fn(url, options);
return pRequest
.then(getData)
.then(tap(data => debug(JSON.stringify(data, null, 2))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good!

@kewitz
Copy link
Contributor Author

kewitz commented Mar 23, 2021

@patcon this is going to be deployed soon but we're currently having trouble with a non-related dependency build process.

@kewitz kewitz restored the refact/transferwise-quotes-v2 branch March 24, 2021 18:07
@kewitz kewitz deleted the refact/transferwise-quotes-v2 branch November 3, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refact TransferWise to use Quote V2 endpoint Interac fees through Transferwise not properly reflected in OC
3 participants