-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Transfer)Wise QuoteV2 Refactor #5726
Conversation
d95ef25
to
1969c80
Compare
1969c80
to
d2001ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement!
@patcon I think this has not been deployed in production yet
const pRequest = data ? fn(url, data, options) : fn(url, options); | ||
return pRequest | ||
.then(getData) | ||
.then(tap(data => debug(JSON.stringify(data, null, 2)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good!
@patcon this is going to be deployed soon but we're currently having trouble with a non-related dependency build process. |
Resolves opencollective/opencollective#4008
Resolves opencollective/opencollective#3965