Fix paypal adaptive transactions fx rate #8216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
force-pushed
the
fix/paypal-adaptive-transactions-fx-rate
branch
from
dc0c4b0
to
ede5860
Compare
znarf
reviewed
Nov 29, 2022
| // Validate | ||
| try { | ||
| await models.Transaction.validate(debit, { validateOppositeTransaction: false }); | ||
| await models.Transaction.validate(credit, { validateOppositeTransaction: false }); |
znarf
reviewed
Nov 29, 2022
| @@ -1876,6 +1876,12 @@ export async function payExpense(req: express.Request, args: Record<string, unkn | |||
| try { | |||
| // Pay expense based on chosen payout method | |||
| if (payoutMethodType === PayoutMethodTypes.PAYPAL) { | |||
| if (expense.collective.currency !== host.currency) { | |||
|
Script ran successfully, deploying the fix to prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix opencollective/opencollective#4021
All cases left in DB where PayPal expenses paid manually.
I believe I remember a bug where we would use
USDas the default currency somewhere in the "Mark as paid" process, which probably messed up most of these expenses. I was not able to find the relevant issue/PR.There are a few (mostly,
opencollectiveinc) where I can't really explain what happens, the FX rate was wrong even though we were only usingUSD.This PR:
1.host.currency!==collective.currency. We know this can cause problems, and since we're Deprecate/Remove PayPal adaptive opencollective#5923 it doesn't seem worth working on a fix.transaction.data.isManualflag on manually paid expenses, as it would have simplified the investigation to have an easy flag to surface that these expenses were paid manuallyChangelog
When run, the script will impact the following: