Feature/virtual card release payment methods #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key was using the index which caused removed components to still appear and that was sometimes preventing new ones from appearing. Will solve opencollective/opencollective#1419 See opencollective/opencollective#1336
Following changes also included: - Regroup duplicated code to generate labels for payment methods under the `PaymentMethodLabel` component - Payment method labels can now be translated
|
This pull request is automatically deployed with Now. |
znarf
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Require opencollective/opencollective-api#1519
Show virtual cards in edit collective payment methods list and fix multiple issues related to this form.
Assumptions made for this PR
Fixes the following issues
Refactor opportunity
The new
PaymentMethodLabelcomponent should be used inOrderFormto render the select options. It has been created in this intent (returns non-wrapped strings) and will add support for internationalization to the existing labels for free. This will be the object of another PR.