-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress enhancements #1130
Merged
Merged
Cypress enhancements #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically deployed with Now. |
Betree
force-pushed
the
enhancement/cypress-good-practices
branch
from
November 30, 2018 19:27
de62ab0
to
9a2f2a4
Compare
Betree
force-pushed
the
enhancement/cypress-good-practices
branch
from
November 30, 2018 20:28
eb266a4
to
059812a
Compare
Betree
requested review from
xdamman,
znarf,
HipsterBrown and
marcogbarcellos
November 30, 2018 21:26
Betree
force-pushed
the
enhancement/cypress-good-practices
branch
from
December 3, 2018 08:40
0446c87
to
d49ef97
Compare
HipsterBrown
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 👏 Definitely makes cypress testing more approachable.
znarf
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Resolve opencollective/opencollective#1452
Website URL is now configured by setting
baseUrl
with env variableIf you need to, you can still get the base url with
Cypress.config('baseUrl')
.New cypress
login
commandThis will reduce duplicated code and increase performances as we skip visiting a page, filling a form and submitting it (with some
cy.wait(...)
in the middle) by instead directly fetching the redirect URL from the API.New cypress
fillInputField
commandRemoves the boilerplate
fill
function that we were copying in a lot of tests.Change tests names for clear ordering
Test names used namings like
1-xxx
,2-xxx
...15-xxx
. Cypress sort them alphabetically, so15-xxx
ran before2-xxx
. This is not what one would expect when looking at the test files names.Add
npm run cypress:open
to run cypress browserDisable video recording when running in dev
Makes running tests way faster. We have
npm run cypress:open
if we need to check the results graphically which provides a lot more info than a video.