Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContributeDetails: review how Frequency is handled #1285

Merged
merged 1 commit into from
Jan 14, 2019
Merged

ContributeDetails: review how Frequency is handled #1285

merged 1 commit into from
Jan 14, 2019

Conversation

Betree
Copy link
Member

@Betree Betree commented Jan 14, 2019

Fix opencollective/opencollective#1624

For Tiers

  • if interval=monthly, force "monthly"
  • if interval=yearly, force "yearly"
  • if no interval, force "one time"

Frequency select is disabled if using a tier:

image

For free donation

  • default to "one time"
  • ability to switch to "monthly" or "yearly"

image

@vercel
Copy link

vercel bot commented Jan 14, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@Betree Betree changed the title chore(ContributeDetails): review how Frequency is handled ContributeDetails: review how Frequency is handled Jan 14, 2019
@Betree Betree force-pushed the contribution-flow-frequency branch from 711c569 to c0b6d70 Compare January 14, 2019 14:42
@Betree Betree force-pushed the contribution-flow-frequency branch from c0b6d70 to 03a50e7 Compare January 14, 2019 14:49
HipsterBrown
HipsterBrown approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the styleguide examples as well. 👍

@Betree Betree merged commit 6ab5815 into contribution-flow Jan 14, 2019
@Betree Betree deleted the contribution-flow-frequency branch January 17, 2019 16:19
@PinkDiamond1 PinkDiamond1 mentioned this pull request Jul 31, 2022
Open
@baby636 baby636 mentioned this pull request Jul 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HipsterBrown HipsterBrown HipsterBrown approved these changes

@znarf znarf Awaiting requested review from znarf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Betree @HipsterBrown