Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support to transactions with no expense nor order #4748

Merged
merged 1 commit into from Aug 4, 2020
Merged

Fix support to transactions with no expense nor order #4748

merged 1 commit into from Aug 4, 2020

Conversation

kewitz
Copy link
Contributor

@kewitz kewitz commented Aug 4, 2020 •
edited

@render
Copy link

render bot commented Aug 4, 2020

Your Render PR Server URL is https://oc-styleguide-pr-4748.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bsklq92pp1jjdjar2gr0.

@vercel
Copy link

vercel bot commented Aug 4, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/o048pxkx7
✅ Preview: https://opencollective-frontend-git-fix-transactions-comments.opencollective.vercel.app

znarf
znarf reviewed Aug 4, 2020
View reviewed changes
components/transactions/TransactionDetails.js Outdated
</DetailDescription>
</Box>
)}
{order?.paymentMethod && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paymentMethod should be read at the transaction level I think

Copy link
Contributor Author

@kewitz kewitz Aug 4, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I'll implement the missing resolver and fix it altogether.

znarf
znarf reviewed Aug 4, 2020
View reviewed changes
components/transactions/TransactionDetails.js Outdated
</Box>
)}
</Flex>
{toAccount.host && order?.paymentMethod && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why we should skip this if no paymentMethod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this should be an ||.

@kewitz kewitz merged commit d98f1df into master Aug 4, 2020
@kewitz kewitz deleted the fix/transactions-comments branch August 4, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znarf znarf znarf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kewitz @znarf