Enable Transactions page SSR #4753
Conversation
|
Your Render PR Server URL is https://oc-styleguide-pr-4753.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bskpta2pp1jjdjar50s0. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/nrmh8yjio |
kewitz
force-pushed
the
feat/transactions-page-ssr
branch
from
f85840f
to
29f73c4
Compare
pages/transactions.js
Outdated
| export default withUser(addCollectiveCoverData(TransactionsPage)); | ||
| const addTransactionsData = graphql(transactionsQuery, { | ||
| skip: props => !props.slug, | ||
| name: 'transactionsQuery', |
There was a problem hiding this comment.
This is not a good name, it's confusing.
There was a problem hiding this comment.
I agree that it creates confusion with the query itself, something like transactionsQueryResult would make more sense to me.
There was a problem hiding this comment.
I renamed it to transactionsData.
There was a problem hiding this comment.
I like that we're moving the query to the page, I think it's more suited there. In the same idea, having the pushRoute in the page would make this component usable on other pages if ever needed.
Beside the variable name mentioned above, the rest looks good to me!
pages/transactions.js
Outdated
| @@ -106,4 +213,15 @@ class TransactionsPage extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| export default withUser(addCollectiveCoverData(TransactionsPage)); | |||
| const addTransactionsData = graphql(transactionsQuery, { | |||
| skip: props => !props.slug, | |||
There was a problem hiding this comment.
collectiveSlug is required in
opencollective-frontend/server/pages.js
Line 41 in a34c29a
Related to opencollective/opencollective#3385