RecurringContributions: Fix wrong amounts being displayed #5245
Conversation
|
Your Render PR Server URL is https://oc-styleguide-pr-5245.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bu3vv0gti7j05n9afu0g. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/lc8fz7sxc |
| <FormattedMoneyAmount | ||
| amount={contribution.platformContributionAmount.value * 100} | ||
| amount={contribution.platformContributionAmount.valueInCents} |
There was a problem hiding this comment.
@sbinlondon I replaced all the value * 100 by valueInCents, it's simpler and it avoids an issue with float numbers precision. Let's imagine that someone is contributing $1.10 per month, now please try and type 1.10 * 100 in your console and check the result. What you'll see is the reason why we avoid dealing with floats in general 🙂
For more info about that: https://floating-point-gui.de/
| currency={contribution.amount.currency} | ||
| showCurrencyCode={false} | ||
| precision={0} | ||
| precision="auto" |
There was a problem hiding this comment.
We want to avoid truncating the number, this was showing:
$17.25 USD / month
($15 + $2)
precision="auto" is a good fit for that, it hides the ,00 if there's no decimals but show them if there's any.
Fix an issue that was reported by user for https://opencollective.com/lea-sonda-and-ira-jaffe#section-recurring-contributions
The "Amount contributed" displayed was incorrect, showing total amount + platform tip as the total amount. For this user, it was displaying $120 instead of $110:
There's another issue on the "Contributed to date" amount, but it's API side so we'll do that separately.