Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Expense Form validations when inviting #7533

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

Betree
Copy link
Member

@Betree Betree commented Mar 1, 2022

Resolve opencollective/opencollective#5020
Resolve opencollective/opencollective#5222

UX changes

Submit on behalf (existing user)

  • We now stay on the step profile after selecting a profile to invite
  • We now hide the payout method select when inviting an existing profile (since we don't have access to that tinfo)

Performance changes (opencollective/opencollective#4991)

Could impact performances positively since we're now rendering only the visible components; rather than hiding them in CSS.

@Betree Betree self-assigned this Mar 1, 2022
@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

opencollective-frontend – ./

🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/HW6vi49kHDyYdC9xnMhYHFVGbbcv
✅ Preview: https://opencollective-frontend-git-enhancement-e-737a9c-opencollective.vercel.app

opencollective-styleguide – ./

🔍 Inspect: https://vercel.com/opencollective/opencollective-styleguide/4Z2NRTYF9bBQjpZAmySgrR46ETLm
✅ Preview: https://opencollective-styleguide-git-enhancement-80685a-opencollective.vercel.app

@vercel
Copy link

vercel bot commented Aug 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
opencollective-frontend ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 2:15PM (UTC)
opencollective-styleguide ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 2:15PM (UTC)

@Betree Betree marked this pull request as ready for review August 30, 2022 14:16
@Betree Betree requested a review from kewitz August 30, 2022 14:17
@Betree Betree merged commit 05989d9 into main Aug 30, 2022
@Betree Betree deleted the enhancement/expense-form-invite-validations branch August 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants