Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt out flag DISABLE_OPENCOLLECTIVE #9

Merged
merged 1 commit into from Jul 28, 2018

Conversation

mlucool
Copy link
Contributor

@mlucool mlucool commented Apr 6, 2018

When the environment variable DISABLE_OPENCOLLECTIVE is set to any value other than 0 or false, this flag will let users opt out of the postinstall-cli. This is useful in places that need to parse output and CI.

Fixes: #8, opencollective/opencollective-cli#7 (comment)

@mlucool
Copy link
Contributor Author

mlucool commented Apr 10, 2018

@xdamman Any thoughts?

@xdamman
Copy link
Contributor

xdamman commented Jul 27, 2018

Sorry, I'm only seeing this now 🤦🏻‍♂️
This is a great idea. Can you just move this above the line that reads the package.json.
No need to do that if it's disabled.

@mlucool
Copy link
Contributor Author

mlucool commented Jul 27, 2018

@xdamman fixed

@xdamman
Copy link
Contributor

xdamman commented Jul 27, 2018

Sorry, one more thing: can you update the README.md?
Otherwise people won't find out about this flag.

When set to any value other than 0 or false, this flag will let
users opt out of the postinstall-cli. This is useful in places
that need to parse output and CI.

Fixes: Issues#8, opencollective-cli: Issue#7
@mlucool
Copy link
Contributor Author

mlucool commented Jul 27, 2018

@xdamman done

@xdamman xdamman merged commit f65bb3f into opencollective:master Jul 28, 2018
@moltar
Copy link

moltar commented Jul 28, 2018

Maybe it should look at CI env too, which is commonly set in CI environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants