Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backers cannot contribute recurring donations #2110

Closed
klmansel opened this issue Jun 8, 2019 · 12 comments
Closed

Backers cannot contribute recurring donations #2110

klmansel opened this issue Jun 8, 2019 · 12 comments
Assignees
Labels
bounty bug complexity → simple frontend $100 minimal or unknown complexity bounty (v2)

Comments

@klmansel
Copy link

klmansel commented Jun 8, 2019

Describe the bug
On specific collectives, the Become a backer or contribute options do not allow recurring contributions. The Frequency box is greyed out/disabled. When choosing Or make a one time donation, contributors have the option to choose a monthly or yearly donation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://opencollective.com/wwcodegreenville
  2. As a logged in user, click on either button: contribute or Become a backer
  3. Contribute As - select your user name/profile
  4. Click Next Step
  5. Attempt to change the frequency of the donation (button will be disabled)

Expected behavior
This is confusing behavior and seems it should be the opposite: Choosing contribute or Become a backer should allow contributors to choose a frequency for their donation. Or make a one time donation should disable the frequency drop down.

Screenshots
Video of issue (could not screenshot disabled dropdown due to mouse disappearing in screenshot):

open_collective_backer_issue

Desktop (please complete the following information):

  • OS: MacOS Mojave 10.14.5
  • Browser: Chrome
  • Version 74.0.3729.169

Additional context
As far as I can tell, this is an issue on some, but not all collectives. The link provided is an example of one.

@alanna
Copy link
Contributor

alanna commented Jun 9, 2019

Related to #1789 ?

@klmansel
Copy link
Author

klmansel commented Jun 9, 2019

Yes! I didn’t see that one when searching. This is directly related.

@znarf
Copy link
Member

znarf commented Jun 13, 2019

The "Make a one time donation" link is gonna be updated soon.

@znarf
Copy link
Member

znarf commented Jun 13, 2019

A simple fix would be to have the Frequencyeditable, triggering a modal warning:

If you're changing the frequency, we will not contribute to this specific tier "Gold Sponsor".

  • If "Confirm", redirect to the "custom financial contribution".
  • If "Cancel", nothing

@znarf
Copy link
Member

znarf commented Jul 5, 2019

A $100 bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with $100 when the Pull Request is reviewed, accepted and merged. More info

This bounty is currently reserved to participants of the OSCA (Open Source Africa) event. If not completed there, it will be later open to everyone.

@znarf znarf added osca $100 minimal or unknown complexity bounty (v2) labels Jul 5, 2019
@mikkidollar
Copy link

Hi am micheal from OSCAFRICA , i want to work on this issue

@ghost
Copy link

ghost commented Aug 3, 2019

Hello, I'm Jasper from OSCA, i've opted in to work on this issue...Thanks

@ghost
Copy link

ghost commented Aug 5, 2019

@znarf , I'm currently working on this issue , but i'm a bit confused about what you mean by 'redirect to the "custom financial contribution"'....Kindly explain, so that i can proceed with making my PR

Thanks

@ghost
Copy link

ghost commented Sep 1, 2019

Are you still on this issue? @viva-jasper

@znarf
Copy link
Member

znarf commented Sep 13, 2019

@viva-jasper sorry for late answer. If you're:

  1. contributing to https://opencollective.com/babel/contribute/bronze-sponsors-356/checkout/details
  2. change the frequency
  3. confirm in the modal
  4. you should be "redirected" to https://opencollective.com/babel/donate/details (the amount should ideally stay the same). This should not be a hard redirect, this should be done smoothly by changing the state and/or pushing a new route.

@znarf
Copy link
Member

znarf commented Sep 13, 2019

This bounty is now opened to everyone.

@znarf znarf added bounty and removed osca labels Sep 13, 2019
@alanna alanna added hackathon candidates for internal team hackathon and removed hackathon candidates for internal team hackathon labels Sep 18, 2019
@znarf
Copy link
Member

znarf commented Sep 30, 2019

🏆 This issue was completed by @sudo-kaizen

To claim the bounty, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty bug complexity → simple frontend $100 minimal or unknown complexity bounty (v2)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants