Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the page to edit tiers #3438

Closed
Betree opened this issue Aug 28, 2020 · 24 comments · Fixed by opencollective/opencollective-frontend#8544
Closed

Redesign the page to edit tiers #3438

Betree opened this issue Aug 28, 2020 · 24 comments · Fixed by opencollective/opencollective-frontend#8544
Assignees
Labels
complexity → complex design Global label for anything that the OC Design collective works on. enhancement frontend
Milestone

Comments

@Betree
Copy link
Member

Betree commented Aug 28, 2020

The tiers page has a lot of issues. To name some of them:

image

Best solution for this problem

We need a redesign of this page, that we'll implement as a new one using latest best practices:

Figma file:

Documentation

We'll need to update https://docs.opencollective.com/help/collectives/tiers-goals#tiers

@Betree Betree added complexity → complex frontend enhancement design Global label for anything that the OC Design collective works on. labels Aug 28, 2020
@Betree Betree changed the title Revamp the page to edit tiers Redesign the page to edit tiers Aug 28, 2020
@Memo-Es Memo-Es added this to To triage in Design tasks via automation Sep 4, 2020
@Memo-Es Memo-Es moved this from To triage to Coming up... in Design tasks Sep 29, 2020
@Memo-Es
Copy link

Memo-Es commented Oct 28, 2020

Design update


Proposal to add a custom tier through the settings page

1. Add new tier CTA 2. New custom tier form
Large (Desktop) Large (Desktop)-1

@Betree

@Memo-Es Memo-Es moved this from Coming up... to Done in Design tasks Oct 28, 2020
@alanna
Copy link
Contributor

alanna commented Oct 28, 2020

Visually this is a big improvement @Memo-Es - looking good!

Some notes...

  • I don't like how the 'custom contributions' thing is handled. It's way too complicated, and we shouldn't need all that text to explain how it works. Just make the default and only tier when someone creates a new Collective the custom contribution tier, fully editable, and allow Collectives to treat it like any other tier, including deleting it. Then we won't have to explain it or visually make it different or anything. Right now "enable custom contributions" as designed makes it look like you tick that box to then enable the admin to create custom tiers, but that's not what it means.
  • We can have the action be simply add tier instead of add new custom tier - all tiers are customizable by the admin.
  • What is the purpose of the pre-set tier types? Donation, membership, etc? If they select one of those, they can change all the settings anyway, right? I don't see the need for that. Just let admins create whatever tiers and call them whatever they want and change their settings to be what they need, including recurring or one-off, limited numbers, specific amounts, or to have local tax apply.
  • Change force standalone page to just standalone page - forcing sounds violent. Also add a link from here to the docs page about it, because it's not too clear what it means to users who haven't seen one. If someone is trying to set up a mini-crowdfunding campaign and would like a standalone page, I'm not sure they'll realise this is how to do it.
  • Suggested amounts for flexible tiers are missing? Or is it just this example only shows a fixed amount?
    *The default name should be something we will be happy for them to use if they don't change it. New Generic Tier is not a good choice for this. The word "generic" has negative connotations in English. I suggest the default name for a generic tier is Contribution.
  • We should have default button text instead of a blank box, so they can leave it if they don't want to customise. It should be Contribute.

@Betree
Copy link
Member Author

Betree commented Oct 28, 2020

What is the purpose of the pre-set tier types? Donation, membership, etc?

Those are really important for us to categorize the contribution type, especially for taxes (VAT, GST) that will apply only on certain types (tickets, products, services but not donations). We also adapt the flow based on this, for example products and tickets can have a "Quantity" field, but not donations.

@Betree
Copy link
Member Author

Betree commented Nov 26, 2020

I don't like how the 'custom contributions' thing is handled. It's way too complicated, and we shouldn't need all that text to explain how it works. Just make the default and only tier when someone creates a new Collective the custom contribution tier, fully editable, and allow Collectives to treat it like any other tier, including deleting it. Then we won't have to explain it or visually make it different or anything. Right now "enable custom contributions" as designed makes it look like you tick that box to then enable the admin to create custom tiers, but that's not what it means.

I agree with this, it's the main reason why I specified #3055 that was intended to achieve that. I closed it because the complexity/benefit balance didn't seem right, but on the long term "Custom contribution" being treated as just another tier should really simplify things when it comes to customizing your ways to contribute. I'll re-open it, though I think we should treat it as a separate project because of the complexity.


@Memo-Es From the design, I don't see how to edit a tier?

@Memo-Es
Copy link

Memo-Es commented Nov 27, 2020

Design update


Contribution tiers tab Create/Edit tier modal Edit tier mockup
Large (Desktop) Generic Large (Desktop)-1

New update considering the latest feedback here and here

@Betree
Copy link
Member Author

Betree commented Nov 27, 2020

@Memo-Es the modal should be triggered when you click on a tier from this edit page right?

I love this modal proposal, the fact that it uses a modal allows for inline edition from other places. At some point we had a design of the collective page that included a pencil (edit) and a remove icon next to "Move":

image

With that issue implemented, we should be able to add that easily!

@Betree
Copy link
Member Author

Betree commented Dec 14, 2020

@Memo-Es Some interesting feedback around standalone tier pages here: #3774

@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

@stale stale bot added the stale label Jun 26, 2021
@Memo-Es Memo-Es removed the stale label Jun 28, 2021
@BenJam
Copy link
Contributor

BenJam commented Aug 1, 2022

reviewed design from two years ago and @aminakazi already updated. Designs are pretty much ready.

@aminakazi
Copy link

aminakazi commented Aug 8, 2022

Week 2 Update:
Designed and updated the form according to the new requirements.

Week 3 Tasks

  • Hand over production-ready files to the dev team (@aminakazi)
  • Dev team to set up the base for breaking up the design into bounties.

@BenJam
Copy link
Contributor

BenJam commented Aug 8, 2022

  • @Betree and @SudharakaP to talk through building the framework for bounties to build onto.

@BenJam
Copy link
Contributor

BenJam commented Aug 15, 2022

update tomrrow

@Betree
Copy link
Member Author

Betree commented Aug 16, 2022

We haven't started working on this project yet. We'll try to have it for the week.

@aminakazi
Copy link

The updated production-ready file can be found here .

@Betree
Copy link
Member Author

Betree commented Sep 30, 2022

Current status

➡️ Testing in dev environments (local, staging) & iterating.
Slack channel created on https://opencollective.slack.com/archives/C044GNQ7WBX.

We have the tiers list working:
image

@hdiniz added the ability to create a new tier, with proper validations and instant preview:
Peek 2022-09-30 09-03

This form also supports editing:
Peek 2022-09-30 09-06

And deleting:
Peek 2022-09-30 09-25

Next steps

We have documented some issues we need to iterate on in this Slack thread. We're also looking into #5947.

Once we're happy with the resolution of this feedback, I think we'll be able to roll it out for a larger audience. I suggest doing so in multiple phases:

  1. Enable the Tiers (New!) admin section for the core team & trusted partners. Collect feedback for at least two weeks.
  2. If we're confident enough that it's non-breaking, hide the old Tiers menu entry and make the new one the default. This release should be synced with @opencollective/documentation to make sure we update our docs at the same time.
  3. Migrate Event > Tickets admin section to the new tiers
  4. After a few weeks, remove the legacy tier page

@BenJam
Copy link
Contributor

BenJam commented Oct 24, 2022

prepare for next steps

  • docs
  • release and feedback issues

@Betree
Copy link
Member Author

Betree commented Dec 7, 2022

Let's make sure we close the following issue when we release this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity → complex design Global label for anything that the OC Design collective works on. enhancement frontend
Development

Successfully merging a pull request may close this issue.

8 participants