Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host dashboard: Add Host itself to "Hosted Collectives" #3584

Closed
Betree opened this issue Oct 9, 2020 · 8 comments
Closed

Host dashboard: Add Host itself to "Hosted Collectives" #3584

Betree opened this issue Oct 9, 2020 · 8 comments
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple enhancement frontend host dashboard

Comments

@Betree
Copy link
Member

Betree commented Oct 9, 2020

We want hosts to be able to add funds to themselves when they have activated their host budget.

To do that we should:

  • List the host itself on /host/dashboard/hosted-collectives
  • Make sure the add funds form works for this host
  • Make sure the button to customize the fees is not displayed
@Betree Betree added complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) frontend enhancement host dashboard labels Oct 9, 2020
@alanna
Copy link
Contributor

alanna commented Oct 19, 2020

+1

@znarf
Copy link
Member

znarf commented Oct 20, 2020

I added an entry in the Members table so it appears in the list.

Follow up:

  • Test that Added Funds actually works in production
  • Do that by default when we activate budget for a given Host (entry in the Members table + approvedAt=NOW)
  • Make sure the button to customize the fees is not displayed

@znarf
Copy link
Member

znarf commented Oct 20, 2020

@alanna
Copy link
Contributor

alanna commented Oct 24, 2020

The host Collective is now showing up twice:

Screen Shot 2020-10-25 at 11 42 04 AM

@znarf
Copy link
Member

znarf commented Oct 26, 2020

@alanna Seems something unexpected happened when you turned the budget on. Do you remember anything unusual?

@alanna
Copy link
Contributor

alanna commented Oct 27, 2020

Nothing unusual @znarf - I think I pressed the button and it seemed fine.

@znarf
Copy link
Member

znarf commented Oct 27, 2020

@alanna ok, from the db, it's a bit like it was activated 2 times, so I'm wondering how it happened. Anyway, it's now corrected.

@znarf znarf changed the title Host dashboard: Add Host itslef to "Hosted Collectives" Host dashboard: Add Host itself to "Hosted Collectives" Oct 27, 2020
@znarf
Copy link
Member

znarf commented Dec 9, 2020

It's done.

@znarf znarf closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple enhancement frontend host dashboard
Projects
None yet
Development

No branches or pull requests

3 participants