Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content for updates is not centered #4179

Open
Relequestual opened this issue Apr 12, 2021 · 4 comments
Open

Content for updates is not centered #4179

Relequestual opened this issue Apr 12, 2021 · 4 comments
Assignees
Labels
design Global label for anything that the OC Design collective works on. discussion This issue is being discussed, and is not ready for implementation enhancement frontend stale

Comments

@Relequestual
Copy link

It's less a bug and more a change request but not for a feature...

On an update, such as https://opencollective.com/json-schema/updates/ben-hutton-joins-postman
The content of the update is left aligned.
This makes it hard to read on larger screens. Most similar pages center such content.

I understand the max width is to give parity width wize with email, but the readability of the content on the site could be improved if the container had margin set to auto...

Doing so looks (excactly) like this...
Screenshot 2021-04-12 at 11 27 27

@Betree Betree added design Global label for anything that the OC Design collective works on. frontend and removed bug labels Apr 12, 2021
@snitin315 snitin315 added enhancement and removed design Global label for anything that the OC Design collective works on. labels Apr 12, 2021
@Betree Betree added the design Global label for anything that the OC Design collective works on. label Apr 12, 2021
@snitin315 snitin315 self-assigned this Apr 12, 2021
@Betree Betree added the discussion This issue is being discussed, and is not ready for implementation label Apr 12, 2021
@Betree
Copy link
Member

Betree commented Apr 12, 2021

Ping @Memo-Es, centering the update's content would look more like what you usually see on blogs but it does not match the layout used in other pages of the design system (conversations, expenses, etc.). Feel free to propose an update or to close the issue if you think we should keep the content left-aligned.

@snitin315 this issue needs some input from design before we can move on with the implementation

@Betree Betree assigned Memo-Es and unassigned snitin315 Apr 12, 2021
@snitin315
Copy link
Member

Yeah, lets wait for feedback from the design team 👍🏻

@stale
Copy link

stale bot commented Jul 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

@stale stale bot added the stale label Jul 11, 2021
@Relequestual
Copy link
Author

Not stale!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Global label for anything that the OC Design collective works on. discussion This issue is being discussed, and is not ready for implementation enhancement frontend stale
Projects
None yet
Development

No branches or pull requests

4 participants