Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP, Rename entry to palette, remove root type #34

Merged
merged 5 commits into from
May 15, 2016
Merged

Conversation

rockitbaby
Copy link
Contributor

(opening this pull request, to have a place for discussion with @halfbyte and @theflow)

my goal is to establish the following model of an oco file as good as possible in the core of the library, so all parts of oct are based on a common well formed understanding of oco.

  • a palette can contain entries.
  • entries are of one the following types: palette, color, reference
  • every entry, independent of its type has a name.
  • every entry but root belong to a palette, its called parent (either the file or another child palette, defined by an entry type)
  • the name an the relation to the parent are used to form the path (dotpath)
  • every oco file is a palette without a parent

do you agree on the model?

as a first step i renamed 'Entry' to 'Palette' to be more meaningful.
root is defined by the fact that entry.parent is null.

this change causes some refactoring in renderer and companion app (basically just search and replace type checks).

continue?

@halfbyte
Copy link
Contributor

LGTM. Looks like a nice improvement to me and as long as it helps/helped you express stuff better, I'm all for it.

As I don't want to interfere with your development schedule, please merge this on your own whenever you're ready for it.

❤️ ❤️ ❤️

@rockitbaby rockitbaby merged commit fc00d7e into master May 15, 2016
@rockitbaby rockitbaby deleted the palette-type branch October 25, 2016 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants