[GPT-747][MAJOR] Unified compiler #15

nickbalestra · 2017-06-13T14:27:39Z

No description provided.

matteofigus · 2017-06-13T14:56:27Z

packages/oc-template-jade-compiler/to-be-published/hash-builder.js

@@ -0,0 +1,11 @@
+'use strict';


We may want to investigate https://github.com/puleos/object-hash
It is widely used, dep free, well maintained, apparently, and defaults to sha1+hex.

I can take care of it inside OC as separate PR

Nice! We can definitely use that instead. Thanks for pointing that out 💅

nickbalestra · 2017-06-19T11:33:05Z

addresses #17 ✅

nickbalestra · 2017-06-19T11:39:38Z

addresses #18

nickbalestra · 2017-06-20T15:53:43Z

addresses #20

nickbalestra · 2017-06-21T16:11:29Z

Test Suites: 16 passed, 16 total
Tests:       43 passed, 43 total
Snapshots:   30 passed, 30 total
Time:        6.374s
Ran all test suites.
-----------------------------------------|----------|----------|----------|----------|----------------|
File                                     |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-----------------------------------------|----------|----------|----------|----------|----------------|
All files                                |    92.34 |    72.22 |     97.5 |    92.27 |                |
 infinite-loop-loader                    |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 infinite-loop-loader/lib                |    96.55 |    82.61 |      100 |    96.55 |                |
  infinite-loop-loader.js                |       90 |    63.64 |      100 |       90 |              9 |
  transformLoopWithLimit.js              |      100 |      100 |      100 |      100 |                |
 oc-external-dependencies-handler        |    94.12 |       70 |      100 |    94.12 |                |
  index.js                               |    94.12 |       70 |      100 |    94.12 |             35 |
 oc-get-unix-utc-timestamp               |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 oc-hash-builder                         |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 oc-minify-file                          |    83.33 |       25 |      100 |    83.33 |                |
  index.js                               |    83.33 |       25 |      100 |    83.33 |          24,25 |
 oc-template-jade                        |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 oc-template-jade-compiler               |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 oc-template-jade-compiler/lib           |    94.74 |       75 |      100 |    94.69 |                |
  compile.js                             |    91.89 |       60 |      100 |    91.67 |       31,47,65 |
  compileServer.js                       |    94.44 |     62.5 |      100 |    94.44 |             27 |
  compileStatics.js                      |      100 |    94.44 |      100 |      100 |             14 |
  compileView.js                         |    90.91 |       50 |      100 |    90.91 |          19,48 |
 oc-template-jade-compiler/lib/resources |      100 |      100 |      100 |      100 |                |
  strings.js                             |      100 |      100 |      100 |      100 |                |
 oc-template-jade/lib                    |    76.92 |      100 |    66.67 |       75 |                |
  getCompiledTemplate.js                 |       50 |      100 |        0 |       50 |          5,6,7 |
  getInfo.js                             |      100 |      100 |      100 |      100 |                |
  render.js                              |      100 |      100 |      100 |      100 |                |
 oc-view-wrapper                         |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 oc-webpack                              |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
 oc-webpack/lib/compiler                 |    76.19 |    58.33 |      100 |    76.19 |                |
  index.js                               |    76.19 |    58.33 |      100 |    76.19 | 19,25,26,30,36 |
 oc-webpack/lib/configurator             |      100 |      100 |      100 |      100 |                |
  index.js                               |      100 |      100 |      100 |      100 |                |
-----------------------------------------|----------|----------|----------|----------|----------------|

@mattiaerre ^^ 💅 🌈 🕶

nickbalestra · 2017-06-21T16:14:23Z

@matteofigus should be ready to be reviewd/merged.
note: I'll bring the handlebars template as a follow-up PR as this is already pretty big

mattiaerre · 2017-06-21T16:16:53Z

let's aim for 100% code coverage @nickbalestra 😊

matteofigus

A couple of super little changes

matteofigus · 2017-06-22T11:06:02Z

.travis.yml

-    - node_js: "4"
-    - node_js: "5"
+    # - node_js: "4"
+    # - node_js: "5"


Can we just remove 4 and 5? Thanks

matteofigus · 2017-06-22T11:07:55Z

packages/infinite-loop-loader/README.md

@@ -0,0 +1,60 @@
+# infinite-loop-loader
+[![Build Status](https://travis-ci.org/nickbalestra/infinite-loop-loader.svg?branch=master)](https://travis-ci.org/nickbalestra/infinite-loop-loader)


wrong travis url

Good catch! This could be removed, as we have now the travis badge on root for the whole monorepo

matteofigus · 2017-06-22T11:08:16Z

packages/infinite-loop-loader/README.md

@@ -0,0 +1,60 @@
+# infinite-loop-loader
+[![Build Status](https://travis-ci.org/nickbalestra/infinite-loop-loader.svg?branch=master)](https://travis-ci.org/nickbalestra/infinite-loop-loader)
+[![Standard - JavaScript Style Guide](https://img.shields.io/badge/code%20style-standard-brightgreen.svg)](http://standardjs.com/)


remove standard badge

matteofigus · 2017-06-22T11:09:59Z

packages/oc-external-dependencies-handler/README.md

@@ -0,0 +1 @@
+# oc-external-dependencies-handler


Can we add just a little description of what this is. Same for all the other modules. At least one single sentence that matches package's "description" field.

matteofigus · 2017-06-22T11:12:18Z

packages/oc-get-unix-utc-timestamp/README.md

@@ -0,0 +1 @@
+# oc-get-unix-utc-timestamp


Again, just a little description. Also, can we remove 'oc' from the name? I think this is more of a generic "get unix utc timestamp" module.

matteofigus · 2017-06-22T11:12:54Z

packages/oc-get-unix-utc-timestamp/test/oc-get-unix-utc-timestamp.test.js

@@ -0,0 +1,5 @@
+const getTimeStamp = require('../index.js');
+
+test('Generates correct timestamps everytime its invoked', () => {


matteofigus · 2017-06-22T11:21:04Z

packages/oc-template-jade-compiler/lib/compile.js

+const compileStatics = require('./compileStatics');
+const getUnixUtcTimestamp = require('oc-get-unix-utc-timestamp');
+
+// OPTIONS


can we make this list alphabetic. Also, I don't see here "ocPackage"

nickbalestra · 2017-06-22T12:00:59Z

@matteofigus done

compileView & co

b0e24aa

matteofigus reviewed Jun 13, 2017

View reviewed changes

Nick Balestra added 4 commits June 13, 2017 16:31

wip

aceafeb

server compiler

99e56ba

compile statics & related utilities / orchestration

392f72a

unified compiler modularization

6d88250

nickbalestra mentioned this pull request Jun 17, 2017

Shared packages #17

Closed

Nick Balestra added 7 commits June 19, 2017 12:27

oc-view-wrapper module

e836149

oc-webpack module

c6a6c21

minify-file module

c0b6aee

external-dependencies-handler module

6ff5bb8

timestamp module

86e8a51

hash builder module

32543cd

compiler changes to reference published modules

e6bf446

moved in infinite-loop-loader package

3cc8f41

Nick Balestra added 13 commits June 19, 2017 14:35

jade component mock

4c4bdfe

tests wip

df55bc6

lerna to run tests within each package

64a36bf

lerna orchestration, muting not yet avail test

f9f8c77

tests from oc repo

c19cdef

updated automatic node switcher configs

11a835f

travis at a monorepo level

f7c9ed2

packages licenses

561529f

readmes

e8c1530

unified package.json and packages structure

dbb9d5f

updated mono-repo readme

cff5abb

no need for mono-repo license

8512af8

cleanup infinite-loop

f87f33a

Nick Balestra added 3 commits June 20, 2017 16:36

moar test for the external deps handler

315cc0c

oc webpack tests

3afe50e

remaining tests to be completed

903f3b8

Nick Balestra added 7 commits June 20, 2017 16:58

jest --findRelatedTests in 🚫💩 lint-staged config

b7fd3b5

test wip

f26a0b3

coverage script command

4091064

jade-compiler tests

5d16a51

cleaned webpack snapshots

059191a

compiler test

593cf62

minors fixes

410a772

nickbalestra assigned mattiaerre and unassigned mattiaerre Jun 21, 2017

nickbalestra requested a review from mattiaerre June 21, 2017 16:19

nickbalestra changed the title ~~[WIP] Unified compiler~~ [MAJOR] Unified compiler Jun 21, 2017

hoisting common devDeps

87fa121

nickbalestra changed the title ~~[MAJOR] Unified compiler~~ [GPT-747][MAJOR] Unified compiler Jun 21, 2017

matteofigus requested changes Jun 22, 2017

View reviewed changes

Nick Balestra added 5 commits June 22, 2017 12:44

updated travis config

f033a27

infinite loader travis/standard badge removal

74bdeac

updated readmes

c278f8d

typo

2ea0675

requires albhabetically ordered

9cfeef2

matteofigus approved these changes Jun 22, 2017

View reviewed changes

nickbalestra merged commit 1ba8534 into master Jun 22, 2017

nickbalestra deleted the unified-compiler branch June 22, 2017 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GPT-747][MAJOR] Unified compiler #15

[GPT-747][MAJOR] Unified compiler #15

nickbalestra commented Jun 13, 2017

matteofigus Jun 13, 2017

matteofigus Jun 13, 2017

nickbalestra Jun 13, 2017

nickbalestra commented Jun 19, 2017 •

edited

nickbalestra commented Jun 19, 2017 •

edited

nickbalestra commented Jun 20, 2017

nickbalestra commented Jun 21, 2017 •

edited

nickbalestra commented Jun 21, 2017

mattiaerre commented Jun 21, 2017

matteofigus left a comment

matteofigus Jun 22, 2017

matteofigus Jun 22, 2017

nickbalestra Jun 22, 2017

matteofigus Jun 22, 2017

matteofigus Jun 22, 2017

matteofigus Jun 22, 2017

matteofigus Jun 22, 2017

matteofigus Jun 22, 2017

nickbalestra commented Jun 22, 2017

		@@ -0,0 +1,60 @@
		# infinite-loop-loader
		[![Build Status](https://travis-ci.org/nickbalestra/infinite-loop-loader.svg?branch=master)](https://travis-ci.org/nickbalestra/infinite-loop-loader)

		@@ -0,0 +1,5 @@
		const getTimeStamp = require('../index.js');

		test('Generates correct timestamps everytime its invoked', () => {

[GPT-747][MAJOR] Unified compiler #15

[GPT-747][MAJOR] Unified compiler #15

Conversation

nickbalestra commented Jun 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickbalestra commented Jun 19, 2017 • edited

nickbalestra commented Jun 19, 2017 • edited

nickbalestra commented Jun 20, 2017

nickbalestra commented Jun 21, 2017 • edited

nickbalestra commented Jun 21, 2017

mattiaerre commented Jun 21, 2017

matteofigus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickbalestra commented Jun 22, 2017

nickbalestra commented Jun 19, 2017 •

edited

nickbalestra commented Jun 19, 2017 •

edited

nickbalestra commented Jun 21, 2017 •

edited