[DX-296] Mocks can have the same signature as real plugins #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
approved these changes
Dec 20, 2017
src/cli/domain/get-mocked-plugins.js
Outdated
| .join('/'); | ||
| }, | ||
| parentDir = pathToResolve ? getParent(pathToResolve) : rootDir; | ||
| const getParent = x => |
There was a problem hiding this comment.
I think is never too bad to name things for what they are: pathToResolve or similar in this case instead of x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a plugin to have, apart from the simplified signature (exporting a synchronous execution function) a regular signature (similar to the real plugins) with an exported asynchronous register() function and a synchronous exported execute() function.
This is part of a bigger work to allow mocks to be more usable and possibly wrapping the whole real plugin - for better local DX and testing.
PS
In case of plugin initialisation error, I improved the error message providing some code snippets for modelling a mock with the correct signature: