Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP Baseline Profile Improvements #53

Open
lindappwu opened this issue Nov 1, 2023 · 4 comments · May be fixed by #70
Open

OCP Baseline Profile Improvements #53

lindappwu opened this issue Nov 1, 2023 · 4 comments · May be fixed by #70
Assignees
@lindappwu
Labels
Fixed The fix is in a pull request profile-baseline

Comments

@lindappwu
Copy link

In the OCP Baseline Profile, the mandatory requirements for Chassis doesn't seem to be designed for the sub-Chassis components, especially for the components embedded on the board.

		"Chassis": {
			"PropertyRequirements": {
                                ...
				"Model": {},
				"SerialNumber": {},
				"PowerState": {},
				"Links": {
					"PropertyRequirements": {
						"ManagedBy": {}
					}
				}
			}
		},

Suggest to add conditional requirements based on the value of ChassisType, similar to https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/blob/d06fae818ea59292a5652d4d1dbf85b7423864ae/Server/OCPServerHardwareManagement.v1_0_1.json#L25C12-L25C34
@jcleung5549
Copy link
Contributor

The general direction is to create a new baseline from which sub-Chassis profiles can extend. The current Baseline profile was created to form the baseline for managing platforms (servers, network devices, storage platforms, etc).

@jcleung5549 jcleung5549 added the Discussion Required Issue/Resolution requires discussion label Dec 5, 2023
@jautor
Copy link
Contributor

jautor commented Dec 5, 2023

I'll take a look at this as well.

@jcleung5549
Copy link
Contributor

jcleung5549 commented Jan 9, 2024 •
edited

1/9 - In the interim, modify baseline to condition the requirement based on ChassisType. Linda has a profile fragment for this.

@jcleung5549 jcleung5549 mentioned this issue Jan 23, 2024
Closed
lindappwu pushed a commit to lindappwu/HWMgmt-OCP-Profiles that referenced this issue Jan 26, 2024
Create OCPBaselineHardwareManagement.v1_1_0.json
42a9ddd 
Add minor update for issue opencomputeproject#53
@lindappwu lindappwu mentioned this issue Jan 26, 2024
Merged
@jcleung5549 jcleung5549 mentioned this issue Feb 6, 2024
Open
jcleung5549 added a commit to lindappwu/HWMgmt-OCP-Profiles that referenced this issue Mar 12, 2024
@jcleung5549
Merge branch 'baseline1_1' into fix-opencomputeproject#53
f079b8f
@jcleung5549 jcleung5549 added Fixed The fix is in a pull request and removed Discussion Required Issue/Resolution requires discussion labels Mar 12, 2024
@jcleung5549 jcleung5549 assigned lindappwu and unassigned jautor Mar 12, 2024
@jcleung5549
Copy link
Contributor

Baseline v1.1 merged. Await HW Mgmt Project to release.

lindappwu pushed a commit to lindappwu/HWMgmt-OCP-Profiles that referenced this issue Mar 28, 2024
Merge branch 'fix-opencomputeproject#53' of https://github.com/lindap…
2c0956c 
…pwu/HWMgmt-OCP-Profiles into fix-opencomputeproject#53
@lindappwu lindappwu linked a pull request Mar 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindappwu lindappwu

Labels
Fixed The fix is in a pull request profile-baseline
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ReadRequirement for UseCases functions lindappwu/HWMgmt-OCP-Profiles
3 participants
@jautor @jcleung5549 @lindappwu