-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VRF policy driven TE #2217
VRF policy driven TE #2217
Conversation
} | ||
} | ||
rule { | ||
sequence-id: 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this rule#17 be split into below two rules to map to a catch-all default class-map ?
rule {
sequence-id: 17
l2 {
ethertype: ETHERTYPE_IPV4
}
action {
network-instance: "DEFAULT"
}
}
rule {
sequence-id: 18
l2 {
ethertype: ETHERTYPE_IPV6
}
action {
network-instance: "DEFAULT"
}
}
network_instance: "TE_VRF_222" | ||
} | ||
IPv4Entry {203.0.113.101/32 (TE_VRF_222)} -> NHG#9 (DEFAULT VRF) -> { | ||
{NH#3, DEFAULT VRF, weight:1,ip_address=192.0.2.103}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be different NH# , NH#3 is associated with 192.0.2.104 ?
{NH#3, DEFAULT VRF, weight:1,ip_address=192.0.2.103}, | ||
backup_next_hop_group: 201 // decap to DEFAULT VRF | ||
} | ||
IPv4Entry {192.0.2.103/32 (DEFAULT VRF)} -> NHG#10 (DEFAULT VRF) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
192.0.2.103/32 prefix has NH entry over Port5, so this should be another VIP ?
|
||
* Install a BGP route resolved by ISIS in default VRF to rout traffic out of DUT port-8. | ||
|
||
* Install an 0/0 static route in ENCAP_VRF_A and ENCAP_VRF_B pointing to the DEFAULT VRF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OC Local routing model doesn't look to be having a nexthop network-instance leaf.
So should this default static route in Encap VRF be part of the DUT startup baseconfig ?
* inner_src: `ipv4_inner_src` | ||
* inner_dst: `ipv4_inner_encap_match` | ||
* dscp: `dscp_encap_no_match` | ||
* outter_src: `ipv4_outter_src_111` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible typo - used outter instead of outer
Pull Request Test Coverage Report for Build 7281992563
💛 - Coveralls |
Received approval from internal b/304783132. I'll merge this so we have a starting point. @singh-prem and @arvbaska1, can you help raise separate PRs or bugs for your suggestion/questions? Thanks. |
Hi @xw-g , could you please just clarify this question here https://github.com/openconfig/featureprofiles/pull/2207/files#r1406820552 ? , i think also applies to this PR. |
|
Add test plans for VRF policy driven TE