Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRF policy driven TE #2217

Merged
merged 6 commits into from
Dec 20, 2023
Merged

VRF policy driven TE #2217

merged 6 commits into from
Dec 20, 2023

Conversation

xw-g
Copy link
Collaborator

@xw-g xw-g commented Oct 5, 2023

Add test plans for VRF policy driven TE

@xw-g xw-g requested a review from nachikethas October 5, 2023 21:25
@xw-g xw-g requested review from a team as code owners October 5, 2023 21:25
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 5, 2023

Pull Request Functional Test Report for #2217 / e339439

No tests identified for validation.

Help

}
}
rule {
sequence-id: 17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this rule#17 be split into below two rules to map to a catch-all default class-map ?

rule {
      sequence-id: 17
      l2 {
          ethertype: ETHERTYPE_IPV4
      }
      action {
            network-instance: "DEFAULT"
      }
}
 
rule {
      sequence-id: 18
      l2 {
          ethertype: ETHERTYPE_IPV6
      }
      action {
            network-instance: "DEFAULT"
      }
}

network_instance: "TE_VRF_222"
}
IPv4Entry {203.0.113.101/32 (TE_VRF_222)} -> NHG#9 (DEFAULT VRF) -> {
{NH#3, DEFAULT VRF, weight:1,ip_address=192.0.2.103},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be different NH# , NH#3 is associated with 192.0.2.104 ?

{NH#3, DEFAULT VRF, weight:1,ip_address=192.0.2.103},
backup_next_hop_group: 201 // decap to DEFAULT VRF
}
IPv4Entry {192.0.2.103/32 (DEFAULT VRF)} -> NHG#10 (DEFAULT VRF) -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

192.0.2.103/32 prefix has NH entry over Port5, so this should be another VIP ?


* Install a BGP route resolved by ISIS in default VRF to rout traffic out of DUT port-8.

* Install an 0/0 static route in ENCAP_VRF_A and ENCAP_VRF_B pointing to the DEFAULT VRF.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OC Local routing model doesn't look to be having a nexthop network-instance leaf.
So should this default static route in Encap VRF be part of the DUT startup baseconfig ?

* inner_src: `ipv4_inner_src`
* inner_dst: `ipv4_inner_encap_match`
* dscp: `dscp_encap_no_match`
* outter_src: `ipv4_outter_src_111`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible typo - used outter instead of outer

Copy link

Pull Request Test Coverage Report for Build 7281992563

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.407%

Totals Coverage Status
Change from base Build 7281926507: 0.0%
Covered Lines: 1611
Relevant Lines: 3196

💛 - Coveralls

@xw-g
Copy link
Collaborator Author

xw-g commented Dec 20, 2023

Received approval from internal b/304783132. I'll merge this so we have a starting point.

@singh-prem and @arvbaska1, can you help raise separate PRs or bugs for your suggestion/questions? Thanks.

@arvbaska1
Copy link
Contributor

Received approval from internal b/304783132. I'll merge this so we have a starting point.

@singh-prem and @arvbaska1, can you help raise separate PRs or bugs for your suggestion/questions? Thanks.

Hi @xw-g , could you please just clarify this question here https://github.com/openconfig/featureprofiles/pull/2207/files#r1406820552 ? , i think also applies to this PR.

@cfernanz cfernanz self-assigned this Dec 20, 2023
@xw-g xw-g merged commit 3e32b01 into main Dec 20, 2023
12 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Dec 21, 2023
@xw-g
Copy link
Collaborator Author

xw-g commented Dec 21, 2023

Received approval from internal b/304783132. I'll merge this so we have a starting point.
@singh-prem and @arvbaska1, can you help raise separate PRs or bugs for your suggestion/questions? Thanks.

Hi @xw-g , could you please just clarify this question here https://github.com/openconfig/featureprofiles/pull/2207/files#r1406820552 ? , i think also applies to this PR.

#2514

singh-prem pushed a commit to b4firex/featureprofiles that referenced this pull request Jan 12, 2024
@self-maurya self-maurya deleted the vrf_policy_te branch May 13, 2024 06:12
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants