Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generated python gnmi file #1

Closed
aaronbee opened this issue Aug 14, 2017 · 5 comments
Closed

Add generated python gnmi file #1

aaronbee opened this issue Aug 14, 2017 · 5 comments

Comments

@aaronbee
Copy link

Would you mind including the gnmi_pb2.py file in this repo and keeping it updated with gnmi.proto changes? This would make it easier for Python projects using gnmi.
@awly
Copy link
Contributor

awly commented Aug 14, 2017

Fixed via 040628c

@awly awly closed this as completed Aug 14, 2017
@aaronbee
Copy link
Author

Looks like the python files got lost again. When you add them back, can you also include gnmi_pb2_grpc.py?

@awly
Copy link
Contributor

awly commented Aug 23, 2017

Sorry, restored now ba4491d

What do you mean gnmi_pb2_grpc.py? The Python proto stubs were compiled with gRPC plugin (e.g. --python_out=plugins=grpc:proto/gnmi).

@aaronbee
Copy link
Author

For example: https://github.com/grpc/grpc/blob/master/examples/python/route_guide/route_guide_pb2_grpc.py

This file is generated for me when I compile the .proto file using the instructions from here:

$ python -m grpc_tools.protoc -I../../protos --python_out=. --grpc_python_out=. ../../protos/route_guide.proto

@awly
Copy link
Contributor

awly commented Aug 24, 2017

Done: 0ca9511

@kboyapa1 kboyapa1 mentioned this issue Sep 1, 2018
Closed
mkhsueh added a commit that referenced this issue Aug 23, 2019
@mkhsueh
Suppress duplicate notifications at update granularity
69c8afb 
Change duplicate suppression for a non-atomic notification to fail on individual
updates when multiple are present, instead of failing the whole notification early on a
single bad update.
  1) Prevents accrual of stale leaves due to a single duplicate update failing the whole
     notification (remaining updates not processed).
  2) Allows deletes to independently complete when duplicate updates are present.
  3) Avoids errant implicit deletions, since some updates (including duplicates) will no
     longer be stale due to #1.

Increase test coverage for interaction between updates/deletes/stale leaves and suppression.

PiperOrigin-RevId: 258587893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronbee @awly