Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonIetfVal of JsonVal in the form a json array might not be processed properly. #256

Open
Tobelightbeam opened this issue Oct 18, 2023 · 2 comments

Comments

@Tobelightbeam
Copy link

https://github.com/openconfig/gnmic/blob/345c505534afda492e27b7c1afd76cd72ae095e9/formatters/event.go#L260C1-L260C1

JsonVal or JsonIetfVal might be in the form of a json array, but in the code corresponding to the above link, the json array form is classified into the default case. Will this kind of handling cause any problems?

@Tobelightbeam Tobelightbeam changed the title JsonIetfVal of JsonVal in the form 藕粉 JsonIetfVal of JsonVal in the form a json array Oct 18, 2023
@Tobelightbeam Tobelightbeam changed the title JsonIetfVal of JsonVal in the form a json array JsonIetfVal of JsonVal in the form a json array might not be processed properly. Oct 18, 2023
@karimra
Copy link
Collaborator

karimra commented Oct 20, 2023

While it's not a common practice for a router to send a value as a list at the top level of a JSON object, it typically sends multiple notifications, each containing a JSON dictionary as a value. However, it might be a good idea to address this potential issue.

@Tobelightbeam
Copy link
Author

@karimra thanks for your reply. If you have any plan to do this, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants