Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go-grpc gRPC code generation plugin downgraded #173

Open
aaronbee opened this issue Mar 6, 2024 · 3 comments
Open

protoc-gen-go-grpc gRPC code generation plugin downgraded #173

aaronbee opened this issue Mar 6, 2024 · 3 comments

Comments

@aaronbee
Copy link

aaronbee commented Mar 6, 2024

In commit 64e82de the generated gRPC code looks to have started using a downgraded protoc plugin. It used to be the case that the protoc-gen-go plugin handled Go code generation for protobuf messages and gRPC services. The gRPC service code generation was later moved into protoc-gen-go-grpc. It seems that in that commit support went backwards.

This can be seen by the fact that *_grpc.pb.go files have been deleted, merging the gRPC service definitions into the other .pb.go and the line that exists in the deleted file:

const _ = grpc.SupportPackageIsVersion7

is now:

const _ = grpc.SupportPackageIsVersion6

Note the version has gone down.

This is a backwards incompatible change because certain symbols are deleted, such as UnimplementedCertificateManagementServer. In the current version of gRPC it is required that code references this when implementing a CertificateManagement service server, by removing it code that supported the current version of gRPC no longer compiles.

@robshakir
Copy link
Contributor

Aaron -- thanks for flagging this. This looks like an error. Let me chase it up.

@aaronbee
Copy link
Author

aaronbee commented May 7, 2024

Fixed by #190

@aaronbee aaronbee closed this as completed May 7, 2024
@aaronbee
Copy link
Author

aaronbee commented May 7, 2024

@marcushines #190 looks to have missed regeneration of packet_link_qualification and packet_capture. They are both missing _grpc.pb.go files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants