fix copy in regenerate-files script #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in the original regenerate-files script from https://github.com/openconfig/gnsi/pull/37/files#diff-fc93ffaaee0a108cd0141877980a22c2c5f782b529e4561cd11243753b91eed8 the copy should be from "${BASE}"/"${pkg}"/"${proto}"_go_proto_/"${GNOI_NS}"/"${pkg}"/*.pb.go to the target package rather than the "${BASE}"/"${pkg}"/"${proto}"_go_proto_/"${GNOI_NS}"/"${proto}"/*.pb.go which was in the base patch e.g. the files for packet link qualification will be under linkqual_go_proto_/github.com/openconfig/gnoi/packet_link_qualification/packet_link_qualification.pb.go
|
related issue thread: #173 (comment) |
Pull Request Test Coverage Report for Build 8990651044Details
💛 - Coveralls |
marcushines
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the original regenerate-files script from
https://github.com/openconfig/gnsi/pull/37/files#diff-fc93ffaaee0a108cd0141877980a22c2c5f782b529e4561cd11243753b91eed8
the copy should be from
"${BASE}"/"${pkg}"/"${proto}"_go_proto_/"${GNOI_NS}"/"${pkg}"/*.pb.goto the target package rather than the
"${BASE}"/"${pkg}"/"${proto}"_go_proto_/"${GNOI_NS}"/"${proto}"/*.pb.gowhich was in the base patch
e.g. the files for packet link qualification will be under
linkqual_go_proto_/github.com/openconfig/gnoi/packet_link_qualification/packet_link_qualification.pb.go