Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yang OC models #166

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Remove yang OC models #166

merged 3 commits into from
Mar 19, 2024

Conversation

dplore
Copy link
Member

@dplore dplore commented Mar 4, 2024

Removing the openconfig yang models from the gNSI repository as they are now moved to the openconfig public repository via openconfig/public#1037

@brianneville
Copy link
Contributor

openconfig/public#1037 included an outdated version of gNSI Certz, which has been since updated so that the counter names are different (connection-accepts/connection-rejects/last-connection-accept/last-connection-reject vs access-accepts/access-rejects/last-access-accept/last-access-reject), and the description of these counters has been updated.

see:

gnsi/certz/gnsi-certz.yang

Lines 84 to 109 in e05f3dc

"A collection of counters that were collected by the gRPC during
the authentication process.";
leaf connection-rejects {
type oc-yang:counter64;
description
"The total number of times that gRPC clients have failed
in establishing a connection to the server.";
}
leaf last-connection-reject {
type oc-types:timeticks64;
description
"A timestamp of the last time a gRPC client failed
in establishing a connection to the server.";
}
leaf connection-accepts {
type oc-yang:counter64;
description
"The total number of times that gRPC clients have succeeded
in establishing a connection to the server.";
}
leaf last-connection-accept {
type oc-types:timeticks64;
description
"A timestamp of the last time a gRPC client succeeded
in establishing a connection to the server.";

modified as of #156

@brianneville
Copy link
Contributor

I've opened a PR to resolve this, please take a look:
openconfig/public#1061

@dplore
Copy link
Member Author

dplore commented Mar 5, 2024

Thanks, will wait to merge this until the changes you proposed are merged just for ease of reference

@dplore
Copy link
Member Author

dplore commented Mar 14, 2024

@marcushines could use your approval to merge this to prevent confusion (such as #175 )

@haussli
Copy link
Contributor

haussli commented Mar 15, 2024

Please mention in the respective READMEs that the models have moved and whither.

@dplore
Copy link
Member Author

dplore commented Mar 15, 2024

Please mention in the respective READMEs that the models have moved and whither.

Done

@marcushines marcushines self-requested a review March 19, 2024 16:04
@dplore dplore merged commit 0342fdd into main Mar 19, 2024
5 checks passed
@dplore dplore deleted the dplore/yang-rm branch March 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants