certz: support specifying cert/key by enum #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use oneofs and enums to specify the source of the certificate and private keys for keys/certs which are already present on the device. In particular this is relevant in the case of attestz, where OIDevID and IDevID certs and keys may be stored in the TPM, see openconfig/attestz#36
marcushines
reviewed
Mar 13, 2024
marcushines
reviewed
Mar 13, 2024
marcushines
approved these changes
Mar 13, 2024
jenia-grunin
approved these changes
Mar 14, 2024
marcushines
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use oneofs and enums to specify the source
of the certificate and private keys for keys/certs which are already present on the device.
In particular this is relevant in the case of attestz, where OIDevID and IDevID certs and keys may be
stored in the TPM, see
openconfig/attestz#36